I think GSC will always be my favorite Pokemon generation because it was so expansive and took long hours to complete.
RSE/ORAS was very fun too because I think it might've had the best overall pokemon in a game. DPP had the best story and villains. RBY is definitely great for the nostalgia.